Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export with https #2152

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix: export with https #2152

merged 2 commits into from
Sep 20, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes: FLI-607

Fixes a bug when trying to export with a call to a server running https

Before

flipt export --address https://flipt-xyz.onrender.com/
2023-09-20T12:25:13.050-0400	FATAL	flipt/server.go:65	unexpected protocol	{"address": "https://flipt-xyz.onrender.com/"}
main.fliptClient
	go.flipt.io/flipt/cmd/flipt/server.go:65
main.(*exportCommand).run
	go.flipt.io/flipt/cmd/flipt/export.go:88
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/[email protected]/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/[email protected]/command.go:1068
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/[email protected]/command.go:992
github.com/spf13/cobra.(*Command).ExecuteContext
	github.com/spf13/[email protected]/command.go:985
main.main
	go.flipt.io/flipt/cmd/flipt/main.go:163
runtime.main
	runtime/proc.go:250

After

» ./bin/flipt export --address https://flipt-xyz.onrender.com
version: "1.2"
namespace: default
flags:
- key: marktest
  name: marktest
  type: BOOLEAN_FLAG_TYPE
  enabled: false

» ./bin/flipt export --address httpxs://flipt-xyz.onrender.com
Error: unexpected protocol httpxs

@markphelps markphelps requested a review from a team as a code owner September 20, 2023 17:19
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #2152 (b34a77e) into main (fef1406) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2152   +/-   ##
=======================================
  Coverage   70.72%   70.72%           
=======================================
  Files          73       73           
  Lines        7067     7067           
=======================================
  Hits         4998     4998           
  Misses       1783     1783           
  Partials      286      286

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps enabled auto-merge (squash) September 20, 2023 17:35
yquansah
yquansah approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markphelps markphelps merged commit 9accec3 into main Sep 20, 2023
25 checks passed
@markphelps markphelps deleted the export-https branch September 20, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yquansah yquansah yquansah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @yquansah